Fix for Brackets app bundle versioning #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.0.0 of AutoPkg required to use this processor
The CFBundleShortVersionString key is not updated by the developers before publishing a new version to Github so has remained at version 1.14.2 even while app is at v2+. If AppDmgVersioner is removed the the version string will be taken directly from Github and this is accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Brackets was taken over / forked from Adobe it appears the the new repository maintainers/developers have been publishing new versions of the app but are not updating the CFBundleShortVersionString inside the Info.plist. The current value for CFBundleShortVersionString is 1.14.2 even though the current published version of the app on Github is 2.2.0 (not including Windows only release). The Brackets download recipe pulls down the correct version but the pkg recipe is relying on the Info.plist when building a pkg file. By removing the AppDmgVersioner processor and leaving just a simple AppPkgCreator on its own the correct version string from Github will be used for both the package receipts and the pkg file name.
I have tested this recipe in my own workflow and can confirm that I'm now getting a newly packaged version with the correct file name and package receipts created (see screenshot below from Suspicious Package). Unfortunately the app still has the wrong value set for the version string but this can't be fixed without breaking the signature. There is a recent issue logged against the Brackets Github repo for this version mismatch and it sounds like they are looking to fix this issue but the changes I have made to this recipe will still continue to work even if the version number issue is resolved by the developers.