Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added method to load variant images and 'variant_cost_price' method #37

Merged
merged 6 commits into from
Mar 5, 2015

Conversation

redglory
Copy link
Contributor

@redglory redglory commented Mar 4, 2015

  1. We only had the possibility to load master variant images so I've added a new method to also be able to load variants images.
  2. Added 'variant_cost_price' method as it wasn't present (variants can have different cost/final prices)
  3. On existing method 'add_images' changed 'get_each_assoc' which expects a '|' to separate each image into @populator.current_value.to_s.split(Delimiters::multi_value_delim) in order to maintain multiple value logic (separated with a ','). I got confused when loading master variant images because it was expecting a '|'.

autotelik pushed a commit that referenced this pull request Mar 5, 2015
Added method to load variant images and 'variant_cost_price' method
@autotelik autotelik merged commit 936b96e into autotelik:master Mar 5, 2015
@autotelik
Copy link
Owner

fantastic work. thanks so much. I'm working on the main datashift code to improve the design - all grew from a spree loader script - so in near future should be able to move this kind of thing @we_can_process_these_anyway out of code and into config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants