sriov: Add 3 cases #4073
Merged
sriov: Add 3 cases #4073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yingshun
force-pushed
the
sriov_at_hostdev
branch
from
f132621
to
cb7eadb
Compare
Yingshun
force-pushed
the
sriov_at_hostdev
branch
from
cb7eadb
to
a31bba7
Compare
dzhengfy
reviewed
Apr 14, 2022
| :raise: TestFail if comparison fails | ||
| """ | ||
| vm_hostdev = vm_xml.VMXML.new_from_dumpxml(vm.name)\ | ||
| .devices.by_device_tag(device_type)[0] |
There was a problem hiding this comment.
I am just wondering if [0] must be what you want? Shall we also consider multiple devices existing? If not, could we add prerequisite in docstring for special usage?
There was a problem hiding this comment.
Updated the docstring, seems we don't need multiple hostdev devices for now.
| hostdev_dict = {'type': 'pci', 'address': {'attrs':{'type': 'unassigned'}}, 'mode': 'subsystem', 'managed': 'yes', 'source': {'untyped_address': %s}} | ||
| - hostdev_interface: | ||
| hostdev_iface_dict = {'managed': 'yes', 'hostdev_address': {'attrs': %s}, 'address': {'attrs':{'type': 'unassigned'}}} | ||
| - deplicate_cust_alias: |
There was a problem hiding this comment.
Oops! Thank you for pointing it out. Updated.
| if p_iface: | ||
| test.fail("There should be no interface, but got %s." % p_iface) | ||
|
|
||
| def test_deplicate_cust_alias(): |
There was a problem hiding this comment.
typo. test_duplicate_cust_alias
This PR adds below cases:
1. RHEL-288445: Hotplug hostdev interface with 'unassigned'
address type
2. RHEL-288444: Start vm with hostdev interface with 'unassigned'
address type
3. RHEL-134143: Hotplug hostdev interface with duplicate custom alias
Signed-off-by: Yingshun Cui <yicui@redhat.com>
Yingshun
force-pushed
the
sriov_at_hostdev
branch
from
a31bba7
to
de3b7f9
Compare
dzhengfy
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds below cases:
RHEL-288445: Hotplug hostdev interface with 'unassigned'
address type
RHEL-288444: Start vm with hostdev interface with 'unassigned'
address type
RHEL-134143: Hotplug hostdev interface with duplicate custom alias
Signed-off-by: Yingshun Cui yicui@redhat.com
depends on avocado-framework/avocado-vt#3362
Test results: 2 cases are failed due to a known BZ.