Support address and rom for hostdev #3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'rom' and 'address' for Hostdev class. Signed-off-by: Yingshun Cui <yicui@redhat.com>
chunfuwen
reviewed
Mar 2, 2022
|
|
||
|
|
||
| class Hostdev(base.TypedDeviceBase): | ||
|
|
||
| __slots__ = ('type', 'mode', 'managed', 'sgio', 'rawio', | ||
| 'source', 'boot_order', 'readonly', 'shareable', | ||
| 'alias', 'model', 'teaming') | ||
| 'alias', 'model', 'teaming', 'rom', 'address') |
There was a problem hiding this comment.
perhaps add simple hostdev xml under class Hostdev(base.TypedDeviceBase):
to make people understand what one typical hostdev looks like.
There was a problem hiding this comment.
A reference link has been added to the top of the code, I don't think we need to 'copy' them.
There was a problem hiding this comment.
Currently already there are some devices xml following up that practice. But it doesn't block approve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'rom' and 'address' for Hostdev class.
Signed-off-by: Yingshun Cui yicui@redhat.com
Test results:
autotest/tp-libvirt#4073 (comment)