-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migration: Update migration with shared tpm case #5803
base: master
Are you sure you want to change the base?
Conversation
Test result: |
3671a13
to
28f1e9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM
cmd = "mount -t ceph %s:6789:/ /var/lib/libvirt/swtpm -o name=admin" % mon_host | ||
if not os.path.exists(swtpm_path): | ||
os.mkdir(swtpm_path) | ||
cmd = "mount -t ceph %s:6789:/ %s -o name=admin,secret=%s" % (mon_host, swtpm_path, ceph_key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you plz reuse utils_disk.mount() instead of shell command line?
cmd = "umount /var/lib/libvirt/swtpm" | ||
process.run(cmd, ignore_status=False, shell=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about reusing utils_disk.umount()?
Use the new directory instead of the swtpm directory as the path to store the image. Signed-off-by: lcheng <lcheng@redhat.com>
Use the new directory instead of the swtpm directory as the path to store the image.