Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sensing): update lidar data field requirement #478

Merged

Conversation

KYabuuchi
Copy link
Contributor

@KYabuuchi KYabuuchi commented Nov 9, 2023

Description

  • I noticed that the lidar data filed types presented on this page do not match the actual ones. So, I fixed them.
type before after reference
T(time) FLOAT32 FLOAT64 distortion_corrector.cpp
I(intensity) UINT8 FLOAT32 ring_outlier_filter.cpp

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
@KYabuuchi KYabuuchi added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Nov 9, 2023
@KYabuuchi KYabuuchi changed the title docs(sensing): modify lidar point field definition docs(sensing): update lidar data field requirement Nov 9, 2023
@KYabuuchi KYabuuchi marked this pull request as ready for review November 9, 2023 06:15
@drwnz
Copy link
Contributor

drwnz commented Nov 9, 2023

@KYabuuchi I think we can merge this for now, but we actually plan to change the point cloud types to the ones in the current documentation in the near future. But we can change back when this happens, to avoid confusion.
@xmfcx does this sound OK to you?

@KYabuuchi
Copy link
Contributor Author

When the point cloud type is updated, we revert this or update. Thanks everyone. 😄

@KYabuuchi KYabuuchi merged commit 6c5d6d6 into autowarefoundation:main Nov 9, 2023
14 checks passed
@KYabuuchi KYabuuchi deleted the fix/pointcloud_preprocess branch November 9, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants