Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Test Codes to Check Simulator Compatibility with Autoware #1105

Open
3 tasks done
Soohyeok-Park opened this issue Jun 15, 2022 · 5 comments
Open
3 tasks done
Assignees
Labels
status:stale Inactive or outdated issues. (auto-assigned) type:new-feature New functionalities or additions, feature requests.

Comments

@Soohyeok-Park
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Purpose

  • To ensure that any simulator is compatible with the latest version of Autoware
  • Ultimately, streamlining the development process of Autoware-compatible simulators

Possible approaches

A very simple method to check the compatibility of MORAI SIM: Drive with Autoware is included in this documentation, which can give a very brief idea at least.
Link

Definition of done

[Current] cover the interface between the simulator and Autoware
[Future] test would cover other requirements defined in the documentation (related discussion link)

@sglee-morai
Copy link

sglee-morai commented Jun 22, 2022

Basic Structure

  1. Common Test Code = Manual Testing Code
  • Python
  • Working as a ROS Node
  1. Test Code for MORAI SIM: Drive
  • Based on Common Test Code
  • Test Automation Feature
    • pytest
    • MSC (MORAI SIM Control API): test setup / tear teardown method

@sglee-morai
Copy link

sglee-morai commented Jul 6, 2022

Update 22-07-06

Want to ask for a review: TierIV to test run the code.
However, I have a question regarding this, though. When a certain person (MORAI in this case) asks other members to run the code in their machine, how he or she can do that?

For me to have Soohyeok's code in my machine, I had to do the followings

  • open terminal
  • change working directory to ~/autoware/src/universe
  • add another remote - Soohyeok's Autoware.Universe repository (which is a fork from the original Autoware.Universe repository)
  • git pull from Soohyeok's remote
  • git checkout [ Soohyeok's latest commit]

Is this a typical process for other members as well in case wanting to get the code and run it in his/her local machine?

@WJaworskiRobotec
Copy link
Contributor

To remove morai msgs from the repo.

I will test the code with TierIV Sim.

@Soohyeok-Park Soohyeok-Park changed the title Check Simulator's Compatibility with Autoware Creating Test Codes to Check Simulator Compatibility with Autoware Jul 6, 2022
@mitsudome-r mitsudome-r removed the priority:high High urgency and importance. label Jul 12, 2022
@WJaworskiRobotec
Copy link
Contributor

Tests work with TierIV Sim. I've approved the PR but there are some issues with CI tests.

@stale
Copy link

stale bot commented Sep 13, 2022

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale Inactive or outdated issues. (auto-assigned) type:new-feature New functionalities or additions, feature requests.
Projects
Development

No branches or pull requests

5 participants