#301: Changed layout in fragment_task_create to TableLayout

[mrwrob]

As with #302, the fragment_task_create layout has been changed to TableLayout. "Save and finish" button moved to the bottom (https://preview.uxpin.com/dc276af793ed5a347736f473bdabe8c5112f8983#/pages/87956602/simulate/sitemap?mode=i)

Resolves #185 #301

[mikolevy]

Great! On a larger device (Nexus 7, API 24) it works fine but unfortunately, during testing on the smaller one (Nexus 5X, API 23) I faced with a crash. Steps to reproduce:

• Run an app on Nexus 5X, API 23
• Select 'Create Task'
• App crashes

Stack:

Process: pg.autyzm.friendly_plans, PID: 5961
                  java.lang.NullPointerException: Attempt to invoke virtual method 'int android.view.View.getVisibility()' on a null object reference
                      at android.widget.LinearLayout.forceUniformHeight(LinearLayout.java:1409)
                      at android.widget.LinearLayout.measureHorizontal(LinearLayout.java:1397)
                      at android.widget.TableRow.onMeasure(TableRow.java:113)
                      at android.view.View.measure(View.java:18788)
                      at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:5951)
                      at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1465)
                      at android.widget.TableLayout.measureChildBeforeLayout(TableLayout.java:461)
                      at android.widget.LinearLayout.measureVertical(LinearLayout.java:748)
                      at android.widget.TableLayout.measureVertical(TableLayout.java:473)
                      at android.widget.TableLayout.onMeasure(TableLayout.java:436)
                      at android.view.View.measure(View.java:18788)
                      at android.widget.ScrollView.measureChildWithMargins(ScrollView.java:1283)
                      at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
                      at android.widget.ScrollView.onMeasure(ScrollView.java:340)
                      at android.view.View.measure(View.java:18788)
                      at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:5951)
                      at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
                      at android.view.View.measure(View.java:18788)
                      at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:5951)
                      at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1465)
                      at android.widget.LinearLayout.measureHorizontal(LinearLayout.java:1112)
                      at android.widget.LinearLayout.onMeasure(LinearLayout.java:632)
                      at android.view.View.measure(View.java:18788)
                      at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:5951)
                      at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
                      at android.view.View.measure(View.java:18788)
                      at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:5951)
                      at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1465)
                      at android.widget.LinearLayout.measureVertical(LinearLayout.java:748)
                      at android.widget.LinearLayout.onMeasure(LinearLayout.java:630)
                      at android.view.View.measure(View.java:18788)
                      at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:5951)
                      at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
                      at com.android.internal.policy.PhoneWindow$DecorView.onMeasure(PhoneWindow.java:2643)
                      at android.view.View.measure(View.java:18788)
                      at android.view.ViewRootImpl.performMeasure(ViewRootImpl.java:2100)
                      at android.view.ViewRootImpl.measureHierarchy(ViewRootImpl.java:1216)
                      at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1452)
                      at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1107)
                      at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6013)
                      at android.view.Choreographer$CallbackRecord.run(Choreographer.java:858)
                      at android.view.Choreographer.doCallbacks(Choreographer.java:670)
                      at android.view.Choreographer.doFrame(Choreographer.java:606)
                      at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:844)
                      at android.os.Handler.handleCallback(Handler.java:739)
                      at android.os.Handler.dispatchMessage(Handler.java:95)
                      at android.os.Looper.loop(Looper.java:148)
                      at android.app.ActivityThread.main(ActivityThread.java:5417)
                      at java.lang.reflect.Method.invoke(Native Method)
                      at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
                      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

I double check it on the master branch and it doesn't crash there. I think the problem is somehow related with TableLayout and it's configuration

If you'd have any problems with reproducing an error please let me know :)

[mrwrob]

Fixed for small devices

[malsolec]

Hi, looking at the commits date, I think the commits may not be pushed. Could you please verify if that's all to review?
I tested it and it fixed #301, but for #302 there are still problems.

1. Picture added with short name, adding mode -> X is not fully visible, when it should be

2. Picture added with long name, edit mode -> any buttons on the right are not visible, when they should be