Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Cargo.lock #24

Merged
merged 1 commit into from
May 31, 2024
Merged

Sync Cargo.lock #24

merged 1 commit into from
May 31, 2024

Conversation

themadprofessor
Copy link
Contributor

Recently I created an AUR Git Package, and the AUR Guidelines recommend using cargo fetch --frozen for reproducible builds. Looks like something caused Cargo.lock and Cargo.toml to desync, which causes cargo fetch --frozen to fail.

Would it also be possible to tag releases on the main branch as soon as they are released? The AUR Git package bases its version of the last tag on main. When a new version is released and the main branch doesn't have the new tag, people mark the package as out-of-date, even though it contains the "latest" code.

@auyer auyer added the 🐛 Bug Something isn't working label May 31, 2024
@auyer
Copy link
Owner

auyer commented May 31, 2024

Hmm interesting. I have to look into this.

The desync was probably my fault.

I am currently making the release based on a release branch instead of the main branch.
When developing locally, we point to the relative path for libprotonup, but when making a release, I need to publish the lib to crates.io first.

Reference commit in the release branch:
7daa68a

Changing it in main would make it annoying to anyone that wants to clone the repo and test things.

@auyer
Copy link
Owner

auyer commented May 31, 2024

Yeah, I found what caused the desync.
I created the release in a single commit.
The build for protonup-rs happens right after libprotonup is published to crates.io.
But the lock file could not have the updated information, because they were not available yet when I created the commit.

Well, we have to find another way then.
I will merge this PR, but we can keep discussing this here or we can create an issue specific for this.

Also, thanks for taking this project to the AUR!
I wanted to create a bin repo, but haven't looked into it yet.

@auyer auyer merged commit 41bd568 into auyer:main May 31, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants