Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: stop the process even if the wrapper expects more data #322

Merged

Conversation

valnoel
Copy link
Member

@valnoel valnoel commented Aug 12, 2020

This PR fixes the case when the wrapper expects some more data to complete the wrapping, while the process should stop since the ending condition is reached. This case happens when the process is ending by a generated stream (black or silence).

Fix the processed frames counter
Fix the process progress check depending on the wrapping status
@coveralls
Copy link

coveralls commented Aug 12, 2020

Coverage Status

Coverage increased (+0.07%) to 78.502% when pulling 30be155 on fix/stop_process_even_if_the_wrapper_expects_more_data into 8cc0912 on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-78.4%) to 0.0% when pulling 30be155 on fix/stop_process_even_if_the_wrapper_expects_more_data into 8cc0912 on develop.

@valnoel valnoel merged commit 406013b into develop Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants