trace: provide appName and version from Config (#1893)

Signed-off-by: Dan Laine <daniel.laine@avalabs.org>
Signed-off-by: Stephen Buttolph <stephen@avalabs.org>
Co-authored-by: Dan Laine <daniel.laine@avalabs.org>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>

config/config.go

@@ -49,6 +49,7 @@ import (
 	"github.com/ava-labs/avalanchego/utils/set"
 	"github.com/ava-labs/avalanchego/utils/storage"
 	"github.com/ava-labs/avalanchego/utils/timer"
+	"github.com/ava-labs/avalanchego/version"
 	"github.com/ava-labs/avalanchego/vms/platformvm/reward"
 	"github.com/ava-labs/avalanchego/vms/proposervm"
 )
@@ -1248,6 +1249,8 @@ func getTraceConfig(v *viper.Viper) (trace.Config, error) {
 		},
 		Enabled:         true,
 		TraceSampleRate: v.GetFloat64(TracingSampleRateKey),
+		AppName:         constants.AppName,
+		Version:         version.Current.String(),
 	}, nil
 }
 

trace/tracer.go

@@ -14,9 +14,6 @@ import (
 
 	sdktrace "go.opentelemetry.io/otel/sdk/trace"
 	semconv "go.opentelemetry.io/otel/semconv/v1.4.0"
-
-	"github.com/ava-labs/avalanchego/utils/constants"
-	"github.com/ava-labs/avalanchego/version"
 )
 
 const (
@@ -36,6 +33,9 @@ type Config struct {
 	// If >= 1 always samples.
 	// If <= 0 never samples.
 	TraceSampleRate float64 `json:"traceSampleRate"`
+
+	AppName string `json:"appName"`
+	Version string `json:"version"`
 }
 
 type Tracer interface {
@@ -68,15 +68,15 @@ func New(config Config) (Tracer, error) {
 	tracerProviderOpts := []sdktrace.TracerProviderOption{
 		sdktrace.WithBatcher(exporter, sdktrace.WithExportTimeout(tracerExportTimeout)),
 		sdktrace.WithResource(resource.NewWithAttributes(semconv.SchemaURL,
-			attribute.Stringer("version", version.Current),
-			semconv.ServiceNameKey.String(constants.AppName),
+			attribute.String("version", config.Version),
+			semconv.ServiceNameKey.String(config.AppName),
 		)),
 		sdktrace.WithSampler(sdktrace.TraceIDRatioBased(config.TraceSampleRate)),
 	}
 
 	tracerProvider := sdktrace.NewTracerProvider(tracerProviderOpts...)
 	return &tracer{
-		Tracer: tracerProvider.Tracer(constants.AppName),
+		Tracer: tracerProvider.Tracer(config.AppName),
 		tp:     tracerProvider,
 	}, nil
 }