Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace: provide appName and version from Config #1893

Merged
merged 6 commits into from Sep 22, 2023

Conversation

najeal
Copy link
Contributor

@najeal najeal commented Aug 22, 2023

Why this should be merged

This resolves #1883

How this works

This deletes the usage of constants in the trace package. Values are provided from the Config.

Copy link
Collaborator

@danlaine danlaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

trace/tracer.go Outdated Show resolved Hide resolved
@danlaine danlaine added the monitoring This primarily focuses on logs, metrics, and/or tracing label Aug 22, 2023
@StephenButtolph StephenButtolph added this to the v1.10.9 milestone Aug 22, 2023
@StephenButtolph StephenButtolph modified the milestones: v1.10.9, v1.10.10 Aug 25, 2023
@StephenButtolph StephenButtolph modified the milestones: v1.10.10, v1.10.11 Sep 19, 2023
config/config.go Outdated Show resolved Hide resolved
Signed-off-by: Stephen Buttolph <stephen@avalabs.org>
@StephenButtolph StephenButtolph added this pull request to the merge queue Sep 22, 2023
Merged via the queue into ava-labs:dev with commit 3c9a2e6 Sep 22, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monitoring This primarily focuses on logs, metrics, and/or tracing
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants