Skip to content

Commit

Permalink
fixup: Add TODO to avoid unnecessary restart of bootstrap node
Browse files Browse the repository at this point in the history
  • Loading branch information
marun committed May 22, 2024
1 parent 8366e5a commit 7f88552
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tests/fixture/tmpnet/network.go
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,10 @@ func (n *Network) Bootstrap(ctx context.Context, w io.Writer) error {
return n.RestartNode(ctx, w, bootstrapNode)
}

// TODO(marun) This last restart of the bootstrap node might be unnecessary if:
// - sybil protection didn't change
// - the node is not a subnet validator

// Ensure the bootstrap node is restarted to pick up configuration changes. Avoid using
// RestartNode since the node won't be able to report healthy until other nodes are started.
if err := bootstrapNode.Stop(ctx); err != nil {
Expand Down

0 comments on commit 7f88552

Please sign in to comment.