vms/platformvm: Disable AddValidatorTx and AddDelegatorTx
#2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
changed the base branch from
master
to
update-platformvm-tx-builder
This reverts commit 6ae8541.
dhrubabasu
requested review from
abi87,
gyuho,
marun,
danlaine and
StephenButtolph
as code owners
dhrubabasu
changed the title
vms/platformvm: Disable AddValidatorTx and AddDelegatorTxvms/platformvm: Disable AddValidatorTx and AddDelegatorTx
StephenButtolph
approved these changes
Jan 30, 2024
JacobEverly
approved these changes
Jan 30, 2024
patrick-ogrady
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Implements https://github.com/avalanche-foundation/ACPs/blob/main/ACPs/62-disable-addvalidatortx-and-adddelegatortx.md
These transactions have been superseded by
AddPermissionlessValidatorTxandAddPermissionlessDelegatorTxsincev1.9.0. We are now onv1.11.0with Durango which is sufficient for downstream to update to the new transaction types which include BLS keys for validators.How this works
AddValidatorTx and AddDelegatorTx should be marked as dropped when added to the mempool after Durango activation. Any blocks including these transactions should be considered invalid.
How this was tested
CI