vms/platformvm: Add missing txs to txs.Builder
#2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
requested review from
abi87,
danlaine and
StephenButtolph
as code owners
abi87
reviewed
Jan 25, 2024
dhrubabasu
commented
Jan 30, 2024
| // rewardAddress: address to send reward to, if applicable | ||
| // keys: keys providing the staked tokens | ||
| // changeAddr: address to send change to, if there is any | ||
| NewAddPermissionlessDelegatorTx( |
There was a problem hiding this comment.
This is unused in this PR but is used in the follow-up: #2662
StephenButtolph
approved these changes
Jan 30, 2024
JacobEverly
approved these changes
Jan 30, 2024
patrick-ogrady
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR add
NewAddPermissionlessValidatorTxandNewAddPermissionlessDelegatorTxtotxs.Builder. This struct is only used in testing so these new functions hard-code inSubnet=PrimaryNetworkand generates a bls key on the fly.There is active work being done to remove reliance on this struct in favor of the wallet so wanted to keep this PR simple to unblock the testing changes in #2662.
How this works
Add methods
How this was tested
CI