Skip to content
This repository was archived by the owner on Aug 21, 2026. It is now read-only.

[chain] Multidimensional Fees + FIFO Mempool - #352

Merged
patrick-ogrady merged 116 commits into
mainfrom
storage-fees
Aug 22, 2023
Merged

patrick-ogrady merged 116 commits into
mainfrom
storage-fees

Conversation

@patrick-ogrady

@patrick-ogrady patrick-ogrady commented Aug 13, 2023

Copy link
Copy Markdown
Contributor

Resolves: #96
Resolves: #73

TODO

@patrick-ogrady patrick-ogrady changed the title [fees] Overhaul Storage Fees + Add State Burn [fees] Overhaul Storage Fees + Add State Burn + FIFO Mempool Aug 15, 2023
Comment thread chain/fee_manager.go Fixed
Comment thread chain/fee_manager.go Fixed
@patrick-ogrady patrick-ogrady changed the title [chain] Multi-Dimensional Fees + FIFO Mempool [chain] Multidimensional Fees + FIFO Mempool Aug 21, 2023
@patrick-ogrady
patrick-ogrady marked this pull request as ready for review August 22, 2023 15:07
@patrick-ogrady
patrick-ogrady merged commit 3cd53d1 into main Aug 22, 2023
@patrick-ogrady
patrick-ogrady deleted the storage-fees branch August 22, 2023 15:07
@deuszx

deuszx commented Sep 11, 2023

Copy link
Copy Markdown

Hey @patrick-ogrady . I haven't read the whole PR (and its dependants) but how (if at all) do you enforce that every validator uses a FIFO for its mempool? Theoretically, I can fork the code and change my mempool algo to something else than FIFO and it still will work properly?

@patrick-ogrady

patrick-ogrady commented Sep 11, 2023

Copy link
Copy Markdown
Contributor Author

Hey @patrick-ogrady . I haven't read the whole PR (and its dependants) but how (if at all) do you enforce that every validators uses a FIFO for its mempool? Theoretically, I can fork the code and change my mempool algo to something else than FIFO and it still will work properly?

That's correct. It was not a design goal to "enforce" FIFO (I'm not sure enforcing some mempool behavior is even theoretically possible without a TEE and trusted broadcast). You could replace FIFO with any mempool algo you want and the on-chain fees would still work as expected (they update independently of any off-chain knowledge/behavior -> they more or less perform an on-chain auction for resources, how flow is provided to that auction is up to the builder but using non-FIFO won't break it).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tokenvm] Overhaul Fees Add cost per state key read

3 participants