[vm] Block Pruning (Default to Only Keeping Last 768 Blocks) #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stalled with no acceptable summaries (when network wasn't producing blocks): |
|
patrick-ogrady
commented
Sep 3, 2023
patrick-ogrady
commented
Sep 3, 2023
|
Error on E2E: Not setting accepted status following state sync 🤦 |
patrick-ogrady
commented
Sep 4, 2023
| return err | ||
| } | ||
| vm.preferred, vm.lastAccepted = blk.ID(), blk | ||
| if err := vm.loadAcceptedBlocks(ctx); err != nil { |
There was a problem hiding this comment.
Because we store the AcceptedBlockWindow in memory, we don't need an index of BlockID -> Height/Block.
patrick-ogrady
changed the title
patrick-ogrady
changed the title
patrick-ogrady
commented
Sep 4, 2023
| return | ||
| } | ||
|
|
||
| // Exit early if we don't have any blocks other than genesis (which |
There was a problem hiding this comment.
Turns out this backfill was not being triggered in a number of cases where it should have. I moved to vm to trigger during ANY bootstrap.
|
Odd that pebble size continues to increase (should be much smaller than this): ... doesn't seem like deletion is actually occurring |
|
Cause for this is that WAL is being limited at ~100MB: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #130
Resolves: #302
Resolves: #448
ava-labs/avalanchego#1929
TODO
state sync not workingGetStateSummaryValidityWindowalternatively, could allow block building past the validity window timestamp from last accepted (would not solve problem of transitioning out of dynamic mode, which is only safe to do after accept)Set"bootstrap-retry-enabled"to false (does this prevent node from cycling when can't fetch old blocks during normal bootstrapping?)does not prevent this from happening, can do from thesyncervmclientwhat if network is in recovery and we can't get the frontier, we don't want to exit on bootstrap?-> [vm] Prevent node from entering full bootstrap via config #438We can process sustained 7.5k TPS (500 accts) without surpassing 2.8 GB of disk storage (all in).