Test send specific receipts (Part 2) #113
Conversation
gwen917
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam,
geoff-vball,
bernard-avalabs and
feuGeneA
as code owners
gwen917
changed the title
…est-case-insufficient-gas
…est-case-insufficient-gas
… test-case-send-specific-receipts
…est-case-insufficient-gas
… test-case-send-specific-receipts
| amount, err := subnetATeleporterMessenger.CheckRelayerRewardAmount(&bind.CallOpts{}, fundedAddress, mockTokenAddress) | ||
| Expect(err).Should(BeNil()) | ||
| Expect(amount).Should(Equal(big.NewInt(10))) | ||
|
|
There was a problem hiding this comment.
Can you add an additional step of sending an arbitrary message from Subnet B -> Subnet A? This message will also include the receipts that were explicitly sent in the above steps. We should check that the relayer reward amount is unchanged, even after the receipt is delivered again.
There was a problem hiding this comment.
sure. Then, will it cover Test receiving a receipt multiple times has no effect case?
There was a problem hiding this comment.
Yup it will! I pointed it out for completeness here, but that will also cover that test case.
gwen917
changed the base branch from
test-case-insufficient-gas
to
general-e2e
…-specific-receipts
gwen917
changed the title
tests/send_specific_receipts.go
Outdated
| Expect(err).Should(BeNil()) | ||
| Expect(amount).Should(Equal(big.NewInt(10))) | ||
|
|
||
| // Send message from Subnet B to Subnet A |
There was a problem hiding this comment.
| // Send message from Subnet B to Subnet A | |
| // Send message from Subnet B to Subnet A to trigger the "regular" method of delivering receipts. | |
| // The next message from B->A will contain the same receipts that were manually sent in the above steps, | |
| // but they should not be processed again on Subnet A. |
tests/send_specific_receipts.go
Outdated
| DestinationAddress: fundedAddress, | ||
| FeeInfo: teleportermessenger.TeleporterFeeInfo{ | ||
| ContractAddress: mockTokenAddress, | ||
| Amount: big.NewInt(5), |
There was a problem hiding this comment.
Can you replace thi and big.NetInt(10) below with variables? E.g. relayerFeePerMessage and totalAccumulatedRelayerFee
Why this should be merged
Implements the following test cases from #94
How this works
See above
How this was tested
New E2E test cases
How is this documented