Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to polkadot-v1.0 #195

Merged
merged 65 commits into from Sep 13, 2023
Merged

Upgrade to polkadot-v1.0 #195

merged 65 commits into from Sep 13, 2023

Conversation

ToufeeqP
Copy link
Contributor

@ToufeeqP ToufeeqP commented Aug 9, 2023 •
edited

Noteworthy changes in the upstream in this upgrade:

  • Removed Header and BlockNumber, Added Block as Config Parameter to frame-system (#14437)
  • Removed native dispatch requirement from frame-benchmarking-cli (#14474)
  • Removed/renamed CLI options and removed backward compatible HTTP server from RPC server (#13384)
  • Enabled GenesisConfig in no_std in Frame (#14108)
  • Used proper error types in try-runtime (#13993)
  • Added serde feature flag to primitives (#13027)
  • Deprecate Currency, balances::transfer, introduce holds and freezing into fungible traits in Balances pallet (#12951)
  • Expose API to fetch metadata for version in Metadata v15 (#13287)
  • Fix longest chain finalization target lookup (grandpa-bug on devnet) (#13289)
  • Get the correct number of connected peers in SyncState (#13700)
  • sc-client-db: Fix PruningMode::ArchiveCanonical (#13361)
  • Runtime API refactor for block ID removal (#13255)
  • Removed wasmi impl from sp-wasm-interface (#14208)
  • Removed sc-consensus-uncles (#13216)

Companion PR

@ToufeeqP
Updated rust toolchain
9286cf9
@ToufeeqP
Incorporated upstream changes into frame-system
e1aa805
@ToufeeqP
Updated packages to use latest support versions
64787cd
@ToufeeqP
Removed uncles & deprecated GenesisConfig
098b5d0
@ToufeeqP
wip: weights v2 & fixed system pallet tests
dc152df
@ToufeeqP
Updated mocks with new frame-system configs
91f9701
@ToufeeqP
wip: Added ExtendedBlock with frame & da headers
8326e83
@ToufeeqP
Updated weights to v2
f056800
@ToufeeqP
Updated da control mocks to fix tests
f6b286d
@ToufeeqP
Updated nomad-updater-manager mocks to fix tests
1019bdf
@ToufeeqP
Updated nomad-home mocks
2268485
@ToufeeqP
Fixed system benchmarkings
2233d60
@ToufeeqP
fmt & refactor
829b666
@ToufeeqP
Added frame-executive as local dep to patch
ebca3a7
@ToufeeqP
fmt fix
87c5245
@ToufeeqP
Updated pallet configs
b7ecdcc
@ToufeeqP
Added code comment for rust bug
cbc7220
@ToufeeqP
commented nomad-da-bridge tests
20e6a72
@ToufeeqP
Removed unintended std feature gate on imports
04925d0
@ToufeeqP
Updated runtime configs
968fd27
@ToufeeqP
pallets: implement for in
0d99a72
@ToufeeqP
pallets: implement Default for GenesisConfig in no_std
9e555bc
@ToufeeqP
Merge branch 'toufeeq/polkadot-v1.0' of https://github.com/availproje…
4dd02a4 
…ct/avail into toufeeq/polkadot-v1.0
@ToufeeqP
Added missing configs & functions to runtime
096c487
@ToufeeqP
Temp: removed da-bridge from runtime
3c4f702
@ToufeeqP
Fixed runtime tests
23c42cc
@ToufeeqP
Fixed kate-rpc's
b2b64bf
@ToufeeqP
Fixed compile errors of node service
8142d01
@ToufeeqP
Merge branch 'develop' into toufeeq/polkadot-v1.0
c349071
@ToufeeqP
Updated kate-rpc to use default HeaderExtension
c3f19df
@ToufeeqP
Copy link
Contributor Author

ToufeeqP commented Sep 7, 2023

Hey, overall LGTM, ggwp on that huge chunk of work.

Few points:

  • Spec version should be increased
  • When applying the runtime upgrade on a dev chain, i got issues decoding blocks (could be because of types needing update on the explorer OR the following point)
  • Some migration some to be missing, when trying the runtime i got this errors :
    image
  • Tested with snapshot, live chain, try-runtime and benchmarks.

Added the FRAME pallets migrations

@ToufeeqP
Copy link
Contributor Author

ToufeeqP commented Sep 7, 2023

Here is the diff between this branch and KateTest network: https://pastebin.com/raw/wDGxsXnv

We need to write migrations for the following pallets:

  • System
  • Balances,
  • ImOnline,
  • NominationPools
  • ElectionProviderMultiPhase
  • And maybe TC and Council

Not sure how you got this list, but with reference to release v1.6.2-rc1, I have added migrations to the pallets which need the migrations. For balances pallet, substrate devs have recommended using the script which calls the extrinsic to migrate the affected storages.

ToufeeqP and others added 4 commits September 7, 2023 09:57
@ToufeeqP
apply review suggestions
60852b4
@Leouarz @ToufeeqP @markopoloparadox
Upgrade/polkadot v1.0 (#218)
a1c246f 
* camel_casing fields of BlockLength

* updated api_dev in avail-subxt

* feat: Added identity pallet to our module list

* feat: Added mandate pallet

* Updated avail-core branch reference to main

* fix migrations

---------

Co-authored-by: Toufeeq Pasha <toufeeq@sovereignwallet.network>
Co-authored-by: Marko Petrlic <petrlic.marko@gmail.com>
@Leouarz
merge upstream
268456e
@Leouarz
merge upstream, generate subxt metadata, add block to scheduler migra…
133ea82 
…tion
@markopoloparadox markopoloparadox force-pushed the toufeeq/polkadot-v1.0 branch 3 times, most recently from 362becc to e06c441 Compare September 13, 2023 12:47
markopoloparadox
markopoloparadox approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@markopoloparadox markopoloparadox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markopoloparadox markopoloparadox merged commit eca1c35 into develop Sep 13, 2023
2 checks passed
@markopoloparadox markopoloparadox deleted the toufeeq/polkadot-v1.0 branch September 13, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markopoloparadox markopoloparadox markopoloparadox approved these changes

@Leouarz Leouarz Leouarz approved these changes

@prabal-banerjee prabal-banerjee Awaiting requested review from prabal-banerjee

@fmiguelgarcia fmiguelgarcia Awaiting requested review from fmiguelgarcia

Assignees

@ToufeeqP ToufeeqP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ToufeeqP @codecov-commenter @markopoloparadox @Leouarz