Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some mortal extrinsic examples #581

Merged
merged 7 commits into from
May 27, 2024
Merged

add some mortal extrinsic examples #581

merged 7 commits into from
May 27, 2024

Conversation

kroos47
Copy link
Contributor

@kroos47 kroos47 commented May 6, 2024

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Feature
  • Bugfix
  • Refactor
  • Format
  • Documentation
  • Testing
  • Other:

Description

Related Issues

Testing Performed

Checklist

  • I have performed a self-review of my own code.
  • The tests pass successfully with cargo test.
  • The code was formatted with cargo fmt.
  • The code compiles with no new warnings with cargo build --release and cargo build --release --features runtime-benchmarks.
  • The code has no new warnings when using cargo clippy.
  • If this change affects documented features or needs new documentation, I have created a PR with a documentation update.

markopoloparadox
markopoloparadox reviewed May 8, 2024
View reviewed changes
avail-js/examples/node-examples/src/tx-balance-transfer.ts Outdated
@@ -64,4 +64,4 @@ const main = async () => {
process.exit(1)
}
}
main()
main()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unwanted change.

@Leouarz Leouarz mentioned this pull request May 15, 2024
Closed
13 tasks
@Leouarz
Copy link
Contributor

Leouarz commented May 24, 2024

@kroos47 @markopoloparadox Could we merge this one ?

Leouarz
Leouarz approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@Leouarz Leouarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix the last bits and merge

@kroos47 kroos47 merged commit b76fb1c into main May 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leouarz Leouarz Leouarz approved these changes

@ToufeeqP ToufeeqP Awaiting requested review from ToufeeqP

@0xSasaPrsic 0xSasaPrsic Awaiting requested review from 0xSasaPrsic

@markopoloparadox markopoloparadox Awaiting requested review from markopoloparadox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kroos47 @Leouarz @markopoloparadox