Adding Procfile and buildpack-run.sh #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request adds the following: Procfile: essential to tell the dyno (this is what runs the application) how to exactly start/run the application. buildpack-run.sh: used in this buildpack: https://github.com/weibeld/heroku-buildpack-run what enables the user to define some commands before the next buildpack. For this build i used this to: Clone the repository avaire. Copy the .git folder one level up. Copy the config.yml to the avaire.jar file. So it can be read. Delete the avaire/ folder. As this cloned one is no longer needed. What will it do? As of now, users can now fork avaire's repo. And edit the config.yml to their liking. When they add the correct buildpacks their build succeeds and will be running. What it won't do? It won't have any effect to how avaire is running now. The files are only used if you prefer hosting in Heroku. The files don't contain any template (app.json), and therefore the user has to add the following themselfs in their heroku app: Buildpacks: (The order matters!) https://github.com/weibeld/heroku-buildpack-run heroku/gradle Enviroment variables: GRADLE_TASK build What is left to do? Avaire could/should use enviroment variables too instead of using the config.yml. This way, users don't expose their bot token/clientid/etc to the public. This way also enables users to quicker change these keys too. And finnaly, some configurations are automatically done for the user. Like the JAWSDB_URL enviroment variable, that is automatically set, when the mysql add-on is added. If you have any question regrading the pull, please feel free to ask :-) Refs: https://devcenter.heroku.com/articles/procfile https://github.com/weibeld/heroku-buildpack-run
Senither
requested changes
Nov 11, 2018
Senither
approved these changes
Nov 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the following:
What will it do?
As of now, users can now fork avaire's repo. And edit the config.yml to their liking. When they add the correct buildpacks their build succeeds and will be running.
What it won't do?
It won't have any effect to how avaire is running now. The files are only used if you prefer hosting in Heroku.
The files don't contain any template (app.json), and therefore the user has to add the following themselfs in their heroku app:
Buildpacks: (The order matters!)
Enviroment variables:
What is left to do?
Avaire could/should use enviroment variables too instead of using the config.yml. This way, users don't expose their bot token/clientid/etc to the public. This way also enables users to quicker change these keys too. And finnaly, some configurations are automatically done for the user. Like the JAWSDB_URL enviroment variable, that is automatically set, when the mysql add-on is added.
The wrapper.jar is needed too, but this will be already added by the maintainer himself.
If you have any question regrading the pull, please feel free to ask :-)
Refs:
https://devcenter.heroku.com/articles/procfile
https://github.com/weibeld/heroku-buildpack-run