Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[http-client] Expose more client attributes / Enhance @Path Annotation #299

Merged
merged 12 commits into from
Oct 5, 2023
Merged

[http-client] Expose more client attributes / Enhance @Path Annotation #299

merged 12 commits into from
Oct 5, 2023

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Oct 4, 2023 •
edited

Adds methods to retrieve more request data for request interception.

  • adds methods to retrieve the method, URI, etc.
  • Can define path via @Client
  • Can use @Path annotation on package/module files to set a package/module wide path prefix

@SentryMan SentryMan changed the title [http-client] Expose more client attributes [http-client] Expose more client attributes / Enhance @Path Annotation Oct 5, 2023
@SentryMan
Copy link
Collaborator Author

@rbygrave yeah, I'm good with this

rbygrave
rbygrave approved these changes Oct 5, 2023
View reviewed changes
http-api/src/main/java/io/avaje/http/api/Path.java Show resolved Hide resolved
http-client/src/main/java/io/avaje/http/client/DHttpClientRequest.java Show resolved Hide resolved
http-client/src/main/java/io/avaje/http/client/DHttpClientRequest.java Show resolved Hide resolved
http-client/src/main/java/io/avaje/http/client/DHttpClientRequest.java Show resolved Hide resolved
http-generator-core/src/main/java/io/avaje/http/generator/core/BaseProcessor.java Show resolved Hide resolved
http-generator-core/src/main/java/io/avaje/http/generator/core/BaseProcessor.java Show resolved Hide resolved
http-generator-core/src/main/java/io/avaje/http/generator/core/ControllerReader.java Show resolved Hide resolved
http-generator-core/src/main/java/io/avaje/http/generator/core/package-info.java Show resolved Hide resolved
tests/test-nima-jsonb/.classpath Show resolved Hide resolved
@rbygrave rbygrave merged commit 4518ab7 into avaje:master Oct 5, 2023
2 checks passed
@rbygrave rbygrave linked an issue Oct 5, 2023 that may be closed by this pull request
Expose more of the HttpClientRequest to Interceptors #298
Closed
@SentryMan SentryMan deleted the client branch October 5, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbygrave rbygrave rbygrave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose more of the HttpClientRequest to Interceptors
2 participants
@SentryMan @rbygrave