Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http-client] Reset base if an http scheme is detected #324

Merged
merged 8 commits into from
Oct 19, 2023

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Oct 18, 2023

now if we do something like:

  @Override
  public Titan titanfall() {
    return client.request()
      .path("https://something.com").path(DROP_POINT)
      .GET()
      .bean(Titan.class);
  }

the base URL will be switched to https://something.com.

  • path will reset the URL buffer if an HTTP scheme is detected in the given string

@SentryMan SentryMan added the enhancement New feature or request label Oct 18, 2023
@SentryMan SentryMan added this to the 2.0 milestone Oct 18, 2023
@SentryMan SentryMan self-assigned this Oct 18, 2023
@rbygrave rbygrave merged commit 1ac29fe into avaje:master Oct 19, 2023
3 checks passed
@SentryMan SentryMan deleted the path branch October 19, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants