Restore autoProvides to exclude http controllers and generated http routes #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…outes The change to autoProvides for Event support also meant that http controllers and http routes started to get included into autoProvides. The problem there is that http controllers are not expected to be public exported types and autoProvides with GenericType doesn't check is the type parameters are public.
You have all kinds of applications, a week ago we had an issue in the discord. Routes provided in one module were not picked up in the other module that gathers all the routes and starts the server. |
|
That isn't related to autoProvides though.
…On Wed, 5 Jun 2024, 12:57 am Josiah Noel, ***@***.***> wrote:
The problem there is that http controllers are not expected to be public
exported types
You have all kinds of applications, a week ago we had an issue in the
discord. Routes provided in one module were not picked up in the other
module that gathers all the routes and starts the server.
—
Reply to this email directly, view it on GitHub
<#587 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABTATKZK66UFSJMLKG2CXLZFW2UJAVCNFSM6AAAAABIX5U632VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBXGQ3TCMZUGQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
With this change if we want to have an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to autoProvides for Event support also meant that http controllers and http routes started to get included into autoProvides. The problem there is that http controllers are not expected to be public exported types and autoProvides with GenericType doesn't check is the type parameters are public.