Removed --source, -S CLI flag. Fixes #937 #1215
Conversation
|
Dunno why |
|
There are more places that needs updating (Use Ack or The Silver Searcher): |
|
Thanks for the tip. I will be back later today. |
There was a problem hiding this comment.
Thanks for picking this up @LasaleFamine. I've just got some comments around the documentation.
docs/recipes/watch-mode.md
Outdated
|
|
||
| You can specify patterns to match files in the folders that would otherwise be ignored, e.g. use `node_modules/some-dependency/*.js` to specify all `.js` files in `node_modules/some-dependency` as a source, even though normally all files in `node_modules` are ignored. Note that you need to specify an exact directory; `{bower_components,node_modules}/**/*.js` won't work. | ||
|
|
||
| If your tests write to disk they may trigger the watcher to rerun your tests. If this occurs you will need to use the `--source` flag. | ||
| If your tests write to disk they may trigger the watcher to rerun your tests. |
There was a problem hiding this comment.
Could you add:
Configure patterns for the source files to avoid this.
readme.md
Outdated
| }, | ||
| "devDependencies": { | ||
| "ava": "^0.17.0" | ||
| } |
There was a problem hiding this comment.
Could you undo the whitespace changes in this file? Your editor may be doing it automatically but the only change that should be here is removing the --source flag.
|
I don't know why all those changes on the README. I think now is fixed. |
|
Nice work @LasaleFamine. Thanks for contributing :) |
Removed every reference within
lib/cli.js. Replaced the reference for theWatcherconstructor withconf.source.I don't know if I need to write some tests or there are other references to remove, I tried to check what seemed more relevant.