-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Bluebird.longStackTraces() #1496
Conversation
Remove Bluebird.longStackTraces() issue (#1492) solved |
Can someone help me with these 2 tests i.e. the Travis CI build and AppVeyor build that take place. |
Travis CI and AppVeyor do not launch exactly the same scripts. Travis CI runs AppVeyor runs The Travis CI script performs additional tasks (xo, flow and tsc): It is not useful to run them on both as they will do the same job of several syntax checking and good practice. I advise you to read how to do a Pull Request: to summarize, on your local repository, you have to do an Finally, the errors you see on Travis CI is XO asking you to change the order of 'import'. Hopefully my answer will help. |
I'm not sure why removing the Bluebird import suddenly causes this linter error, but it should be fine to move up these two imports.
Thanks for your PR @anshulwadhawan! I'm not sure why linting started to fail just because the Bluebird import was removed. I've pushed a commit that should solve that. From the issue:
Would you like to give this a go? We can leave it as a follow-up so no worries if not. |
I am new to Open Source.Can you guys help me with some of my queries: |
Hey @anshulwadhawan,
Not yet, but I'll do so soon.
I've pushed it to your branch, so it's already included in this PR. |
Thank you @anshulwadhawan! |
Fixes #1492.