Remove Bluebird.longStackTraces()

[anshulwadhawan]

Fixes #1492.

[anshulwadhawan]

Remove Bluebird.longStackTraces() issue (#1492) solved

[anshulwadhawan]

Can someone help me with these 2 tests i.e. the Travis CI build and AppVeyor build that take place.
What all do these tests depend on ?

[forresst]

Travis CI and AppVeyor do not launch exactly the same scripts.

Travis CI runs npm run test (default): "test": "xo && flow check test/flow-types && tsc -p test/ts-types && nyc tap --no-cov --timeout=300 --jobs=4 test/*.js test/reporters/*.js"

AppVeyor runs npm run test-win: "test-win": "tap --no-cov --reporter=classic --timeout=300 --jobs=4 test/*.js test/reporters/*.js"

The Travis CI script performs additional tasks (xo, flow and tsc): It is not useful to run them on both as they will do the same job of several syntax checking and good practice.

I advise you to read how to do a Pull Request: to summarize, on your local repository, you have to do an npm install and after your modifications, run npm test. This will launch the same tests as Travis CI.

Finally, the errors you see on Travis CI is XO asking you to change the order of 'import'.

Hopefully my answer will help.

[novemberborn]

Thanks for your PR @anshulwadhawan!

I'm not sure why linting started to fail just because the Bluebird import was removed. I've pushed a commit that should solve that.

From the issue:

As long as we process the require modules early enough, users can still enable long stack traces if they use Bluebird in their own code. It would be good to have an integration test for this though.

Would you like to give this a go? We can leave it as a follow-up so no worries if not.

[anshulwadhawan]

I am new to Open Source.Can you guys help me with some of my queries:
Is my PR merged ? or you want me to use your commit.
Please help me get my first PR merged !
@novemberborn @forresst

[novemberborn]

Hey @anshulwadhawan,

Is my PR merged ?

Not yet, but I'll do so soon.

or you want me to use your commit.

I've pushed it to your branch, so it's already included in this PR.

[novemberborn]

Thank you @anshulwadhawan!