New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete snapshots files after running tests #2036

Merged
merged 1 commit into from Feb 10, 2019

Conversation

Projects
None yet
2 participants
@itaisteinherz
Copy link
Contributor

itaisteinherz commented Feb 8, 2019

This fixes #1511 by recognizing snapshot (.snap) files as source files.

Note that I didn't add an integration test as requested in #1751 (review) since the two assertions I added to the ava-files.js unit tests should be enough. If you still think we need an integration test for this, let me know and I'll add one.

// cc @novemberborn

@novemberborn novemberborn merged commit d066f6f into avajs:master Feb 10, 2019

3 checks passed

codecov/patch 100% of diff hit (target 94.74%)
Details
codecov/project 94.74% (+0%) compared to 65133a8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@novemberborn

This comment has been minimized.

Copy link
Member

novemberborn commented Feb 10, 2019

Thanks @itaisteinherz!

@itaisteinherz itaisteinherz deleted the itaisteinherz:remove-snapshot branch Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment