Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hook afterEachFailedTest #2427

Closed
wants to merge 1 commit into from
Closed

Add hook afterEachFailedTest #2427

wants to merge 1 commit into from

Conversation

bunysae
Copy link
Contributor

@bunysae bunysae commented Mar 22, 2020 •
edited by issuehunt-oss bot
Loading

I liked the idea supposed in issue #840 introducing a new hook. So in this PR i added the hook afterEachFailedTest

IssueHunt Summary

IssueHunt has been backed by the following sponsors. Become a sponsor

@novemberborn
Copy link
Member

Great PR @bunysae!

I've re-read #840 and I don't think we necessarily settled on the right approach. Rather than adding a new hook, what if we added t.passed to the t object provided to test.afterEach.always() hooks?

What do you think?

@bunysae bunysae mentioned this pull request Mar 23, 2020
Merged
@bunysae
Copy link
Contributor Author

bunysae commented Mar 23, 2020

I replaced this PR with #2429.

@bunysae bunysae closed this Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bunysae @novemberborn