Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update t.throws to accept falsy non-Error thrown values when expectation.any is true #3313

Merged
merged 1 commit into from Feb 28, 2024

Conversation

gibson042
Copy link
Contributor

Fixes #3312

@novemberborn novemberborn merged commit be5000a into avajs:main Feb 28, 2024
15 of 16 checks passed
@novemberborn
Copy link
Member

Nice find, thanks @gibson042!

renovate bot added a commit to smartive/zitadel-node that referenced this pull request Feb 28, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ava](https://avajs.dev) ([source](https://togithub.com/avajs/ava)) |
[`6.1.1` -> `6.1.2`](https://renovatebot.com/diffs/npm/ava/6.1.1/6.1.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/ava/6.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/ava/6.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/ava/6.1.1/6.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/ava/6.1.1/6.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>avajs/ava (ava)</summary>

### [`v6.1.2`](https://togithub.com/avajs/ava/releases/tag/v6.1.2)

[Compare Source](https://togithub.com/avajs/ava/compare/v6.1.1...v6.1.2)

#### What's Changed

- Fix throws assertions rejecting falsy values when `any: true` by
[@&#8203;gibson042](https://togithub.com/gibson042) in
[avajs/ava#3313

**Full Changelog**: avajs/ava@v6.1.1...v6.1.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone
Europe/Zurich, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/smartive/zitadel-node).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIxMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kodiakhq bot pushed a commit to cloudquery/plugin-sdk-javascript that referenced this pull request Mar 1, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [ava](https://avajs.dev) ([source](https://togithub.com/avajs/ava)) | devDependencies | patch | [`6.1.1` -> `6.1.2`](https://renovatebot.com/diffs/npm/ava/6.1.1/6.1.2) |

---

### Release Notes

<details>
<summary>avajs/ava (ava)</summary>

### [`v6.1.2`](https://togithub.com/avajs/ava/releases/tag/v6.1.2)

[Compare Source](https://togithub.com/avajs/ava/compare/v6.1.1...v6.1.2)

#### What's Changed

-   Fix throws assertions rejecting falsy values when `any: true` by [@&#8203;gibson042](https://togithub.com/gibson042) in [avajs/ava#3313

**Full Changelog**: avajs/ava@v6.1.1...v6.1.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

t.throws doesn't recognize falsy thrown values
2 participants