Support more test filename conventions #721
Conversation
|
Wait for #713 to land. Then check |
| @@ -80,7 +80,7 @@ var cli = meow([ | |||
| ' ava --init foo.js', | |||
| '', | |||
| 'Default patterns when no arguments:', | |||
| 'test.js test-*.js test/**/*.js' | |||
| 'test.js test-*.js test/**/*.js __tests__/**/*.js **/*.test.js' | |||
There was a problem hiding this comment.
I thought the convention is that __tests__ can be anywhere? Hence why it's wrapped in underscores.
There was a problem hiding this comment.
Oh, is my glob wrong? Should it be **/__tests__/**? That's what I did for my PR to nyc. Forgive my ignorance with glob 😅
There was a problem hiding this comment.
Updated. 👍 I've subscribed to #713. As soon as that gets merged, I'll give this another look.
There was a problem hiding this comment.
Why not __tests__/**/*.js?
|
|
kentcdodds
force-pushed
the
pr/support-more-test-conventions
branch
from
7048016
to
1271010
Compare
|
This has been updated 👍 |
| @@ -17,7 +17,9 @@ function defaultIncludePatterns() { | |||
| return [ | |||
| 'test.js', | |||
| 'test-*.js', | |||
| 'test' | |||
| 'test', | |||
| '**/__tests__/**', | |||
There was a problem hiding this comment.
Are all **/*.js files inside __tests__ tests? If so I think you just need to match **/__tests__ and AVA's built in directory recursion will take over.
|
I imagine that we'll want to add a test for this, but I can't seem to find existing tests for the default inclusion glob... |
Yea. I'm alluding to that in #736. |
| @@ -80,7 +80,7 @@ var cli = meow([ | |||
| ' ava --init foo.js', | |||
| '', | |||
| 'Default patterns when no arguments:', | |||
| 'test.js test-*.js test/**/*.js' | |||
| 'test.js test-*.js test/**/*.js **/__tests__ **/*.test.js' | |||
There was a problem hiding this comment.
Documentation wise it should be **/__tests__/**/*.js, just like the test directory in ava-files is explained as test/**/*.js.
There was a problem hiding this comment.
Good point. Updated 👍
|
LGTM! |
|
Woohoo! This makes my day, thanks @kentcdodds! |
This PR just updates documentation. I couldn't for the life of me find out where this magic happens. Pointers? Thanks!