Support new test file conventions #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| filename: toPath('lib/foo.test.js'), | ||
| errors: [{message: 'Test file is ignored because it is not in `test.js test-*.js test/**/*.js`'}] | ||
| filename: toPath('lib/foo.spec.js'), | ||
| errors: [{message: 'Test file is ignored because it is not in `test.js test-*.js test/**/*.js **/__tests__/** **/*.test.js`'}] |
There was a problem hiding this comment.
**/__tests__/** --> **/__tests__
There was a problem hiding this comment.
You didn't see anything....
kentcdodds
force-pushed
the
pr/support-more-test-conventions
branch
from
aae72f2
to
d1b2237
Compare
|
Let's wait until avajs/ava#721 gets merged, but LGTM at the moment :) |
Closed
| @@ -8,7 +8,9 @@ var createAvaRule = require('../create-ava-rule'); | |||
| var defaultFiles = [ | |||
| 'test.js', | |||
| 'test-*.js', | |||
| 'test/**/*.js' | |||
| 'test/**/*.js', | |||
| '**/__tests__', | |||
There was a problem hiding this comment.
Should be **/__tests__/**/*.js as this plugin doesn't have directory recursion like AVA.
sindresorhus
changed the title
|
@kentcdodds We must also add in the documentation no-ignored-test-files.md, replace: By default, it will search in `test.js test-*.js test/**/*.js`, which you can override by specifying a path when launching AVA or in the [AVA configuration in the `package.json` file](https://github.com/sindresorhus/ava#configuration).By: By default, it will search in `test.js test-*.js test/**/*.js **/__tests__/**/*.js **/*.test.js`, which you can override by specifying a path when launching AVA or in the [AVA configuration in the `package.json` file](https://github.com/sindresorhus/ava#configuration). |
|
This PR has been updated based on feedback :-) |
|
Thanks @kentcdodds 🎉 |
|
|
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avajs/ava#721