Don't trigger no-incorrect-deep-equal for regular expression (#276)

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
avajs · Feb 20, 2020 · a217bee · a217bee
1 parent 26903de
commit a217bee
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/rules/no-incorrect-deep-equal.js b/rules/no-incorrect-deep-equal.js
@@ -34,7 +34,7 @@ const create = context => {
 	const deepEqual = '[callee.property.name="deepEqual"]';
 	const notDeepEqual = '[callee.property.name="notDeepEqual"]';
 
-	const argumentsLiteral = ':matches([arguments.0.type="Literal"],[arguments.1.type="Literal"])';
+	const argumentsLiteral = ':matches([arguments.0.type="Literal"][arguments.0.regex="undefined"],[arguments.1.type="Literal"][arguments.1.regex="undefined"])';
 	const argumentsUndefined = ':matches([arguments.0.type="Identifier"][arguments.0.name="undefined"],[arguments.1.type="Identifier"][arguments.1.name="undefined"])';
 	const argumentsTemplate = ':matches([arguments.0.type="TemplateLiteral"],[arguments.1.type="TemplateLiteral"])';
 

diff --git a/test/no-incorrect-deep-equal.js b/test/no-incorrect-deep-equal.js
@@ -40,6 +40,18 @@ ruleTester.run('no-incorrect-deep-equal', rule, {
 			test('x', t => {
 				t.notDeepEqual(expression, []);
 			});
+		`,
+		`
+			${header}
+			test('x', t => {
+				t.deepEqual(expression, /regex/);
+			});
+		`,
+		`
+			${header}
+			test('x', t => {
+				t.deepEqual(/regex/, expression);
+			});
 		`
 	],
 	invalid: [