Guard direct function calls in prefer-t-regex

Fix #251
avajs · Jun 2, 2019 · c8ddcc3 · c8ddcc3
1 parent 32b45c0
commit c8ddcc3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/rules/prefer-t-regex.js b/rules/prefer-t-regex.js
@@ -37,7 +37,7 @@ const create = context => {
 
 			// First argument is a call expression
 			const isFunctionCall = firstArg.type === 'CallExpression';
-			if (!isFunctionCall) {
+			if (!isFunctionCall || !firstArg.callee.property) {
 				return;
 			}
 

diff --git a/test/prefer-t-regex.js b/test/prefer-t-regex.js
@@ -23,6 +23,7 @@ ruleTester.run('prefer-t-regex', rule, {
 		header + 'test(t => t.true(foo.bar()));',
 		header + 'const a = /\\d+/;\ntest(t => t.truthy(a));',
 		header + 'const a = "not a regexp";\ntest(t => t.true(a.test("foo")));',
+		header + 'test("main", t => t.true(foo()));',
 		// Shouldn't be triggered since it's not a test file
 		'test(t => t.true(/\\d+/.test("foo")));'
 	],