(#168) no-identical-title: Do not report identical titles when using …

…macros
avajs · Feb 9, 2017 · dd5765b · dd5765b
1 parent c2235d8
commit dd5765b
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/rules/no-identical-title.js b/rules/no-identical-title.js
@@ -2,6 +2,7 @@
 const espurify = require('espurify');
 const visitIf = require('enhance-visitors').visitIf;
 const deepStrictEqual = require('deep-strict-equal');
+const util = require('../util');
 const createAvaRule = require('../create-ava-rule');
 
 const purify = node => node && espurify(node);
@@ -37,6 +38,11 @@ const create = context => {
 				return;
 			}
 
+			// Don't flag what look to be macros
+			if (args.length > 2 && !util.isFunctionExpression(args[1])) {
+				return;
+			}
+
 			if (isTitleUsed(usedTitleNodes, titleNode)) {
 				context.report({
 					node,

diff --git a/test/no-identical-title.js b/test/no-identical-title.js
@@ -32,6 +32,25 @@ ruleTester.run('no-identical-title', rule, {
 		// multiple anonymous tests covered by the if-multiple rule
 		header + 'test(t => {}); test(t => {});',
 		header + 'test(t => {}); test.cb(t => {});',
+		// macros
+		` ${header}
+			const macro = (t, value) => { t.true(value); };
+
+			test(macro, true);
+			test(macro, false);
+		`,
+		` ${header}
+			const macro = (t, value) => { t.true(value); };
+
+			test('should work', macro, true);
+			test('should fail', macro, false);
+		`,
+		` ${header}
+			const macro = (t, value) => { t.true(value); };
+
+			test('same title', macro, true);
+			test('same title', macro, false);
+		`,
 		// shouldn't be triggered since it's not a test file
 		'test(t => {}); test(t => {});',
 		'test("a", t => {}); test("a", t => {});'