Fix linting errors from XO 0.17 #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,7 +51,7 @@ const create = context => { | |||
| .filter(info => info.ended); | |||
|
|
|||
| // If this segment or any previous segment is already ended, further statements are not allowed, report as an error. | |||
| if (ended.length) { | |||
| if (ended.length !== 0) { | |||
There was a problem hiding this comment.
Would be more natural here to use > 0.
There was a problem hiding this comment.
Sure, fine by me.
If this nitpick happens a lot for you, then it could probably deserve a linting rule, or options for the explicit-length-check rule. We could have another linting rule for comparing the result of .indexOf.
There was a problem hiding this comment.
An option sounds good. Care to open an issue about it?
There was a problem hiding this comment.
And yes to the indexOf idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix linting errors from XO 0.17