Prevent the no-import-test rule to crash when imported path is not a string
#228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
novemberborn
requested changes
Mar 31, 2019
There was a problem hiding this comment.
I reckon it's better to check the source in the AST visitors rather than converting to a string here. @Manu1400 took that approach in this commit: 2d48704, which was submitted a little earlier as part of #221.
I've asked him to open a separate PR with that approach. Would you mind having a look at that one too?
I made the requested changes. |
|
@GMartigny Can you follow the approach done in 2d48704 ? (Asking since #221 is stale, so no point in waiting for that) |
sindresorhus
changed the title
no-import-test rule to crash when imported path is not a string
That's what I did. Just, instead of checking twice in |
# Conflicts: # rules/no-import-test-files.js # test/no-import-test-files.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #213
(Sorry for the duplicated PR)