Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect flat "plugins" export #358

Closed
wants to merge 1 commit into from
Closed

Remove incorrect flat "plugins" export #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@ module.exports = {
},
},
'flat/recommended': {
plugins: {
ava: 'ava',
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not be removed, just correctly defined: https://eslint.org/blog/2022/08/new-config-system-part-2/#more-powerful-and-configurable-plugins

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works when removed, but it doesn't work in its current state. This is all the effort I have to commit to these changes.

rules: {
...rules,
},
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"repository": "avajs/eslint-plugin-ava",
"sideEffects": false,
"engines": {
"node": "^18.18 || >=20"
"node": "^18.18 || >=20.9"
},
"scripts": {
"integration": "node ./test/integration/test.js",
Expand Down