Add use-t-well rule
#73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ## Fail | ||
|
|
||
| ```js | ||
| import test = from 'ava'; |
There was a problem hiding this comment.
Just checking whether you guys actually read the diffs whistle
jfmengels
force-pushed
the
no-unknown-t-members
branch
from
7b1c688
to
e043fff
Compare
|
No comments. This is perfect. Seriously. 🦄
|
|
:D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
use-t-wellruleI originally wanted to make the rule
no-unknown-assertions, but adding checks to member expressions (t.context, ...) was easy, so I've made the rule more global. It now handles quite a few cases. It looks fine to me now, but I wouldn't be surprised if I missed some edge cases (false positives mostly). (If you guys have a a few projects to test it on, that'd be nice)Let me know what you think :)