Add assertion-arguments rule (fixes #92)
#95
Conversation
|
|
||
| ## Options | ||
|
|
||
| The rule takes one option, a string, which could be either `"always"` (enforces error messages) or `"never"` (forbids assertion messages). If omitted or set to false, assertion messages will be neither enforced nor forbidden. |
There was a problem hiding this comment.
It no longer makes sense to have this as a main boolean option. I think it should rather be part of an options object.
|
Maybe we should also ensure the message argument is a string? I know you could potentially put it in an external string, but most put it inline, so we could just de-opt on non-literal values. Or maybe even use code paths as if it's not inline, it's always in the same file. Could be a follow up tweak. Just want your opinion. |
|
Yeah, I was thinking the same thing, and also checking that If we need to play with code paths, I'd rather put it as a follow-up tweak, still can't figure my head around it ^^' |
jfmengels
force-pushed
the
assertion-arguments
branch
from
8870fea
to
e6ad8c8
Compare
|
Updated |
| t.true(array.indexOf(value) !== -1); | ||
| }); | ||
|
|
||
| /* eslint ava/assertion-arguments: ["error", "never"] */ |
There was a problem hiding this comment.
These comments needs to be updated with the new format.
jfmengels
force-pushed
the
assertion-arguments
branch
from
e6ad8c8
to
513503d
Compare
jfmengels
force-pushed
the
assertion-arguments
branch
from
513503d
to
23fad11
Compare
|
Updated |
|
Splendid work as always @jfmengels 🙌
|
|
Hey, a DiCaprio gif, it's been a while :D |
|
I recently stocked up on more of those. |
Add
assertion-argumentsrule (fixes #92)Willing to change the name of the rule, but this is pretty generic, and maybe some day we'll want to detect the argument types.
Probably to be followed by the deprecation of
assertion-message.