Pulls out explode logic into trait

avalanche-development · Nov 19, 2016 · 121a126 · 121a126
1 parent 9bc35b3
commit 121a126
Show file tree

Hide file tree

Showing 3 changed files with 56 additions and 88 deletions.
diff --git a/src/Parser/ExplodeTrait.php b/src/Parser/ExplodeTrait.php
@@ -0,0 +1,52 @@
+<?php
+
+namespace AvalancheDevelopment\SwaggerRouterMiddleware\Parser;
+
+use Exception;
+
+trait ExplodeTrait
+{
+
+    /**
+     * @param mixed $value
+     * @param array $parameter
+     * @return array
+     */
+    protected function explodeValue($value, array $parameter)
+    {
+        $delimiter = $this->getDelimiter($parameter);
+        return preg_split("@{$delimiter}@", $value);
+    }
+
+    /**
+     * @param array $parameter
+     * @return string
+     */
+    protected function getDelimiter(array $parameter)
+    {
+        $collectionFormat = 'csv';
+        if (isset($parameter['collectionFormat'])) {
+            $collectionFormat = $parameter['collectionFormat'];
+        }
+
+        switch ($collectionFormat) {
+            case 'csv':
+                $delimiter = ',';
+                break;
+            case 'ssv':
+                $delimiter = '\s';
+                break;
+            case 'tsv':
+                $delimiter = '\t';
+                break;
+            case 'pipes':
+                $delimiter = '|';
+                break;
+            default:
+                throw new Exception('Invalid collection format value defined in swagger');
+                break;
+        }
+
+        return $delimiter;
+    }
+}
diff --git a/src/Parser/Path.php b/src/Parser/Path.php
@@ -2,12 +2,13 @@
 
 namespace AvalancheDevelopment\SwaggerRouterMiddleware\Parser;
 
-use Exception;
 use Psr\Http\Message\RequestInterface as Request;
 
 class Path implements ParserInterface
 {
 
+    use ExplodeTrait;
+
     /** @var Request */
     protected $request;
 
@@ -53,47 +54,4 @@ public function getValue()
 
         return $value;
     }
-
-    /**
-     * @param mixed $value
-     * @param array $parameter
-     * @return array
-     */
-    protected function explodeValue($value, array $parameter)
-    {
-        $delimiter = $this->getDelimiter($parameter);
-        return preg_split("@{$delimiter}@", $value);
-    }
-
-    /**
-     * @param array $parameter
-     * @return string
-     */
-    protected function getDelimiter(array $parameter)
-    {
-        $collectionFormat = 'csv';
-        if (isset($parameter['collectionFormat'])) {
-            $collectionFormat = $parameter['collectionFormat'];
-        }
-
-        switch ($collectionFormat) {
-            case 'csv':
-                $delimiter = ',';
-                break;
-            case 'ssv':
-                $delimiter = '\s';
-                break;
-            case 'tsv':
-                $delimiter = '\t';
-                break;
-            case 'pipes':
-                $delimiter = '|';
-                break;
-            default:
-                throw new Exception('Invalid collection format value defined in swagger');
-                break;
-        }
-
-        return $delimiter;
-    }
 }
diff --git a/src/Parser/Query.php b/src/Parser/Query.php
@@ -2,12 +2,13 @@
 
 namespace AvalancheDevelopment\SwaggerRouterMiddleware\Parser;
 
-use Exception;
 use Psr\Http\Message\RequestInterface as Request;
 
 class Query implements ParserInterface
 {
 
+    use ExplodeTrait;
+
     /** @var Request */
     protected $request;
 
@@ -76,47 +77,4 @@ protected function parseQueryString(Request $request)
 
         return $params;
     }
-
-    /**
-     * @param mixed $value
-     * @param array $parameter
-     * @return array
-     */
-    protected function explodeValue($value, array $parameter)
-    {
-        $delimiter = $this->getDelimiter($parameter);
-        return preg_split("@{$delimiter}@", $value);
-    }
-
-    /**
-     * @param array $parameter
-     * @return string
-     */
-    protected function getDelimiter(array $parameter)
-    {
-        $collectionFormat = 'csv';
-        if (isset($parameter['collectionFormat'])) {
-            $collectionFormat = $parameter['collectionFormat'];
-        }
-
-        switch ($collectionFormat) {
-            case 'csv':
-                $delimiter = ',';
-                break;
-            case 'ssv':
-                $delimiter = '\s';
-                break;
-            case 'tsv':
-                $delimiter = '\t';
-                break;
-            case 'pipes':
-                $delimiter = '|';
-                break;
-            default:
-                throw new Exception('Invalid collection format value defined in swagger');
-                break;
-        }
-
-        return $delimiter;
-    }
 }