Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

😴😴😴😩 #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

😴😴😴😩 #7

wants to merge 3 commits into from

Conversation

Aleshkev
Copy link

No description provided.

Copy link
Owner

@avan1235 avan1235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spoczko, tylko tej widoczności pilnuj naprawdę.
brakuje też implementacji toString/zabawy z wołaniem super.toString
0.8 punkta dla Ciebie
uruchomiłeś w ogóle ten kod? xd


public Course(String name, Employee teacher, Set<Student> students) {
this.name = name;
(this.teacher = teacher).addCourseTeached(this);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no potrafisz zaskoczyć 😄


public class Employee extends Person {

private Set<Publication> publications;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

może stosować podejście z final? wtedy jak ktoś zobaczy te deklaracje i definicję w konstruktorze, to wszedzie ma gwarancje , że to nie null


public abstract class Person {
private String name;
static int nextIndex = 0;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😟 a czemu to ma taką widoczność?

import java.util.Map;

public class UniversitySystem {
Map<String, Person> personByName;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

widoczność ponownie nieprawidłowa się wydaje

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants