Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Home Page for Quiz Engine #133

Closed
wants to merge 3 commits into from
Closed

Added a Home Page for Quiz Engine #133

wants to merge 3 commits into from

Conversation

aryajain14
Copy link
Collaborator

Fixes #{issue id}

Summary

  • Added a basic Landing Page for quiz Engine.

Test Plan

  • Test Responsiveness
    • Laptop (1200px)
    • Tablet (760px)
    • Phone (320px)
  • Cross-Browser Testing
    • Chrome
    • Firefox
  • Local Language Support
  • Hygiene and Housekeeping
    • Self-review
    • Comments have been added appropriately
    • Check for bundle size here if adding a package
    • Added relevant details like Labels/Projects/Milestones etc.
    • If adding or removing any environment variable, update docs/ENV.md, .env.example and the Github workflows.
  • Testing
    • Wrote tests
    • Tested locally
    • Tested on staging
    • Tested on an actual physical phone
    • Tested on production
  • Lighthouse Checks
    • Images have alt attributes
    • Any <img> tags have width and height specified
    • Any target="_blank" links have rel="noopener"
    • Only SVGs are used as images. If PNGs are used, their size has been optimised.
    • Any SVG buttons without text have their aria-label attributes set

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (95b3f40) 69.52% compared to head (f585882) 69.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   69.52%   69.79%   +0.27%     
==========================================
  Files          58       59       +1     
  Lines        7422     7572     +150     
  Branches      357      362       +5     
==========================================
+ Hits         5160     5285     +125     
- Misses       2251     2276      +25     
  Partials       11       11              
Flag Coverage Δ
chrome 69.79% <87.81%> (+0.27%) ⬆️
unittest 69.79% <87.81%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/components/InstructionPage.vue 93.71% <100.00%> (ø)
src/components/Questions/Body.vue 93.08% <100.00%> (+0.07%) ⬆️
src/components/Questions/QuestionModal.vue 95.21% <100.00%> (+0.22%) ⬆️
src/components/Splash.vue 95.95% <100.00%> (+0.01%) ⬆️
...c/components/Questions/Palette/QuestionPalette.vue 98.88% <98.11%> (-1.12%) ⬇️
src/views/Player.vue 0.00% <0.00%> (ø)
src/router/index.ts 0.00% <0.00%> (ø)
src/components/LandingPage.vue 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aryajain14 aryajain14 closed this Oct 10, 2023
@aryajain14 aryajain14 deleted the home_page branch October 10, 2023 13:26
@aryajain14
Copy link
Collaborator Author

aryajain14 commented Oct 10, 2023

Made a branch based on another branch by mistake instead of main branch. So closing this branch and PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant