Small UI changes to Instruction Page Component #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 69.99% 73.87% +3.88%
==========================================
Files 59 59
Lines 7632 7626 -6
Branches 448 801 +353
==========================================
+ Hits 5342 5634 +292
+ Misses 2272 1970 -302
- Partials 18 22 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pritamps
reviewed
Nov 2, 2023
| @@ -331,7 +331,7 @@ describe("Player for OMR quizzes", () => { | |||
| cy.get('[data-test="questionSetInstruction-1"').should("exist"); | |||
| cy.get('[data-test="questionSetInstruction-1"').should( | |||
| "have.text", | |||
| "Question Set 1 Description\nYou may attempt only up to 3 questions in this section." | |||
| "Question Set 1 DescriptionYou may attempt only up to 3 questions in this section." | |||
There was a problem hiding this comment.
Shouldn't there be a : or something between Description and You?
There was a problem hiding this comment.
I removed \n and used <br> in instruction component.
have.text was not capturing the <br> between "Description" and subsequent text
|
Why merged without PR? :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.