update

[creaktive]

Changes:

• TRE.xs: compatiple with Perl > v5.10
• tre/: upgraded to 0.8.0

At least, it compiles & passes tests :)

[avar]

This all looks good to me, the only problem is that you clearly care much about this software than I do.

How about I just hand you over the PAUSE rights to it and you upload it yourself? Just tell me your PAUSE id and I'll hand it over to you.

I think it also makes sense that rather than merging this pull request you just alter the distro to point to your repository as the canonical one (I can't remember if it points to it, i.e. whether I was using dzil at the time).

[creaktive]

That's fine for me, my PAUSE id is 'SYP'.
BTW, I can't find re::engine::TRE in CPAN.

[avar]

From PAUSE:

Made SYP primary maintainer of re::engine::TRE.

It used to be on the CPAN but I removed it since it broke with >5.10. I still had the maintainership of it though, until now.

[creaktive]

FYI: https://metacpan.org/module/re::engine::TRE
Does the license auto-generated by Dist::Zilla seems OK for you? It differs from the original one supplied in your POD (no reference to the LGPL from the bound libtre).

[avar]

Sure, looks fine. One thing I'd suggest for future development is to take advantage of the other TRE features (like edit distance) through storing info in %^H which you'd compile into the regexes, e.g.:

 use re::engine::TRE (
     some_config => "value";
 );
 /compile rx here/

[creaktive]

Yes, fuzzy matching is exactly my primary interest in libtre :)

[avar]

Also, FWIW it can sometimes be really hard to cast whatever regex interface you're trying to wrap into the re::engine structure, sometimes it can be really nice, like with:

while ($str =~ /$rx/g)

But other times it can be easier to have an interface like:

my $rx = Regex::Engine::TRE->compile($regex, { fuzzy => 1, fuzzy_factor => 5 });
my $match = $rx->match($str);

Or something, especially if the regex engine you have can take parameters for a complied regex at match time, the re::engine interface can only pass you parameters at regex compile time.