"Special" hull color bugs

[rherriman]

There are a couple issues that revolve around black and white hull colors:

• Leg and scout shapes retain their true team color, and
• The HUD improperly replaces the true team color with black or white

Code is in place that is meant to replace the color of the scout, but it is not working.

The parts for the legs appear in CWalkerActor, itself a subclass of CAbstractPlayer (which is normally where special colors are applied), so I'm not sure why this ever worked in the original source. Maybe a peculiarity with Think C?

The HUD simply reads the value of the longTeamColor property in CAbstractPlayer, so this will need to be set another way. I'd recommend ditching the property entirely if possible and replacing it with a method that converts teamColor to the corresponding long value. In that case we'd want to move it to CAbstractActor.

[rherriman]

I managed to fix the issues I reported above, but it was at the expense of the head color replacement. I now believe CBSPPart::ReplaceColor may not working as intended. We usually see it written as ReplaceColor(kMarkerColor, ...) which suggests that it is meant to replace the color for any polygon that is or was originally set to kMarkerColor. Right now, ReplaceColor is naïve and only applies to polygons that currently match the first parameter.

[rherriman]

I have since confirmed that CBSPPart::ReplaceColor is meant to behave in the way I described above by examining the original source. I intend on fixing the implementation myself, which I anticipate will resolve #3 as well as other small issues not formally catalogued at the moment.

[rherriman]

The problem persists even after #14, the issue being that CWalkerActor removes, replaces, and modifies the hull head color after SetSpecialColor is called. Need to either change the way special colors are implemented (and possibly alter the API just introduced in #14) or figure out how to fix CWalkerActor (and determine why it is doing what it is doing in the first place).