Fix CBSPPart::ReplaceColor
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything in issue avaraline#2 is resolved, unfortunately we now have the opposite problem! The HUD is correct, the leg and scout shapes are correct, but the head retains the true team color. I suspect the issues lies with CBSPPart::ReplaceColor itself, based on how it seems to usually be called. The current implementation replaces `origColor` with `newColor`, but only if `origColor` is actually encountered. If the color (`kMarkerColor`, for example) was already replaced, it won't work.
This was referenced Sep 11, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issues #3 and #9. Feedback welcome since it may not be the most efficient solution.
Also contains additional tweaks to team colors, although the hull head is still not applying "special" colors correctly. (I'm aware of why it isn't working but haven't decided on a solution yet.)