Dark Theme for dialog box. #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 8, 2015 23:43
Demo activity is changed in order to switch from dark theme to light theme.
Dialog theme based on declared theme in the manifest
|
Hi, The code looks much better now.
|
Code reformatted. Modifying ListDialogFragment to change the list view color when dark theme is set. And this class is simplified to some extend.
|
I have formatted the code. Implemented the useDarkTheme method. And simplified the listDialogFragment class to some extend. |
|
Almost there :) It looks like you didn't use our code formatting configuration. Can you reformat with our configuration? |
|
I have reformatted the code. |
|
It looks like we had some files with bad formatting ourselves :) Thanks for fixing that. Good job and thanks for your contribution! |
davidvavra
added a commit
that referenced
this pull request
Feb 18, 2015
Support for dark theme (closes #90)
|
Its always honour to works for open source project and in return receiving thanks.. Looking forward to work more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Dark Theme.
Demo activity is changed in order to switch from dark theme to light theme.