Fix getting hostname for HOST networking #25

alenkacz · 2016-06-11T09:30:49Z

For host networked container it uses localhost as a default

fixes #24

augi · 2016-06-11T13:26:24Z

src/main/groovy/com/avast/gradle/dockercompose/tasks/ComposeUp.groovy

@@ -111,7 +111,9 @@ class ComposeUp extends DefaultTask {
            String gateway
            Map<String, Object> networkSettings = inspection.NetworkSettings
            Map<String, Object> networks = networkSettings.Networks
-            if (networks) {
+            if (networks && networks.every { it.key.toLowerCase().equals("host") }) {
+                gateway = 'localhost'


Please add logger.debug() here.

augi · 2016-06-11T23:45:37Z

src/main/groovy/com/avast/gradle/dockercompose/tasks/ComposeUp.groovy

-            if (networks) {
+            if (networks && networks.every { it.key.toLowerCase().equals("host") }) {
+                gateway = 'localhost'
+                logger.debug("Will use $gateway as host of $serviceName beacuse it is using HOST network")


Typo in beacuse :-)

Typo fixed :)

augi · 2016-06-12T15:42:35Z

Released as 0.3.4

pzbitskiy · 2016-06-13T19:11:11Z

This is actually breaks tests on Windows then boot2docker VM is used:

test.environment.get('WEB_HOST') == 'localhost'
|    |           |               |
|    |           172.17.1.100    false
|    |                           12 differences (0% similarity)
|    |                           (172.17.1.100)
|    |                           (localhost---)

alenkacz · 2016-06-13T19:49:22Z

@pzbitskiy ha! thanks, I'll fix that...

I moved this to #28

alenkacz added 2 commits June 11, 2016 11:29

Fix getting hostname for HOST networking

a290b26

Check that networks exist first

fd7501f

augi reviewed Jun 11, 2016
View reviewed changes

Add logging

a91afa3

augi reviewed Jun 11, 2016
View reviewed changes

Typo

c72a656

augi merged commit 81fe00a into avast:master Jun 12, 2016

alenkacz mentioned this pull request Jun 13, 2016

Failing test on windows with boot2docker #28

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix getting hostname for HOST networking #25

Fix getting hostname for HOST networking #25

alenkacz commented Jun 11, 2016

augi Jun 11, 2016

alenkacz Jun 11, 2016

augi Jun 11, 2016

alenkacz Jun 12, 2016

augi commented Jun 12, 2016

pzbitskiy commented Jun 13, 2016

alenkacz commented Jun 13, 2016 •

edited

Loading

Fix getting hostname for HOST networking #25

Fix getting hostname for HOST networking #25

Conversation

alenkacz commented Jun 11, 2016

augi Jun 11, 2016

Choose a reason for hiding this comment

alenkacz Jun 11, 2016

Choose a reason for hiding this comment

augi Jun 11, 2016

Choose a reason for hiding this comment

alenkacz Jun 12, 2016

Choose a reason for hiding this comment

augi commented Jun 12, 2016

pzbitskiy commented Jun 13, 2016

alenkacz commented Jun 13, 2016 • edited Loading

alenkacz commented Jun 13, 2016 •

edited

Loading