Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inception debugger #52

Merged
merged 5 commits into from
Apr 12, 2020
Merged

Inception debugger #52

merged 5 commits into from
Apr 12, 2020

Conversation

rawsample
Copy link
Member

  • Support for hardware Inception debugger on cortex M3
  • Repetitive read/write operations script as an example

@mariusmue
Copy link
Member

This PR looks great, thanks @rawsample!
I especially enjoy the presence of testcases and some documentation. That being said, would you mind integrating the following improvements? Afterwards, there shouldn't be any roadblocks for a merge. :)

  1. modify avatar2's .travis.yml, so that test_inceptionprotocol.py is executed by our CI (and succeeds)
  2. Extend the documentation of the InceptionTarget class, briefly describing what Inception is, and where to find the paper/hardware? A stripped down version of tests/inception/README.md would do.
  3. the processor-string 'cortexM3' does not match any official writing for M3 boards. I would suggest renaming it to: cortex-m3 or Cortex-M3, with slight preference on the first one.

Thanks again!

@mariusmue
Copy link
Member

Thanks for the update. It looks like the CI fails due to missing requirements? Can you add them to avatar2's setup.py?

Here is the url for the CI-run: https://travis-ci.org/github/avatartwo/avatar2/builds/674018331

@mariusmue mariusmue merged commit b32bfe0 into avatartwo:master Apr 12, 2020
@mariusmue
Copy link
Member

And merged! thanks :)

mariusmue pushed a commit that referenced this pull request Jan 23, 2021
@rawsample @mariusmue
Inception debugger (#52)
e3cfee5 
* Inception debugger target and protocol for cortex M3

See https://github.com/Inception-framework/debugger to build the debugger

* Add tests for read/write operations with the nucleo board example

* Add mockup tests for inception protocol

* PR improvment requests for the inception target

* Add pyusb to install requirement and adjust inception import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rawsample @mariusmue