Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spaces in paths and paths ending in backslash followed by quote #42

Merged
merged 3 commits into from
Sep 26, 2021
Merged

Fix spaces in paths and paths ending in backslash followed by quote #42

merged 3 commits into from
Sep 26, 2021

Conversation

avborup
Copy link
Owner

@avborup avborup commented Sep 26, 2021

The following command would fail for two reasons kitty test '.\test folder\skocimis\':

  1. The path was substituted into the run and compile command before splitting the commands, so the space in the path would cause the commands to receive the source file as .\test.
  2. clap, because of the ending \', returns the path .\test folder\skocimis" (notice the ") - which does not exist.

Closes #40, closes #41.

@avborup avborup added the bug Something isn't working label Sep 26, 2021
@avborup avborup merged commit b5f8c22 into master Sep 26, 2021
@avborup avborup deleted the fix/spaces-in-paths branch September 26, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot give path that ends with backslash and quote Cannot use paths with spaces
1 participant
@avborup